Switch to use registerFileSystemsOnce for SerializablePipelineOptions constructor #34028
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
testStreamsStartCorrectly (org.apache.beam.runners.dataflow.worker.streaming.harness.FanOutStreamingEngineWorkerHarnessTest) failed not related to the change |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
| @@ -59,7 +59,6 @@ public PipelineOptions get() { | |||
| private void readObject(ObjectInputStream is) throws IOException, ClassNotFoundException { | |||
| is.defaultReadObject(); | |||
| this.options = deserializeFromJson(serializedPipelineOptions); | |||
| // TODO https://github.com/apache/beam/issues/18430: remove this call. | |||
There was a problem hiding this comment.
Why is this no longer relevant? This still seems dicy (unconditionally overwriting the options as a side effect of deserialization).
There was a problem hiding this comment.
Restored TODO statement here for now
Abacn
changed the title
|
Hi @Abacn - friendly reminder to fix failures. Thanks! |
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
partly mitigate #18430 ; fix #33965
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.